fix(ui5-popover): restrict arrow going out of bounds #4599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #4581 The arrow of the Popover is now restricted within a range along each dimension. The border-radius of the Popover in the different themes is considered. This solves the issue where the Popover may be opened by a small element placed at the corners of the viewport.
georgimkv
changed the title
ilhan007
reviewed
Jan 21, 2022
georgimkv
requested review from
dimovpetar,
TeodorTaushanov,
alexandar-mitsev,
ilhan007,
LidiyaGeorgieva,
GerganaKremenska and
kskondov
TeodorTaushanov
approved these changes
Jan 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4581
The arrow of the Popover is now restricted within a range along each
dimension. The border-radius of the Popover in the different themes is
considered.
This solves the issue where the Popover may be opened by a
small element placed at the corners of the viewport.