Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing property tooltip for List component #5826

Closed
DanielCavemann opened this issue Sep 16, 2022 · 3 comments · Fixed by #5971
Closed

Missing property tooltip for List component #5826

DanielCavemann opened this issue Sep 16, 2022 · 3 comments · Fixed by #5971
Labels
feature request TOPIC P
Milestone
1.9.0

Comments

@DanielCavemann
Copy link

Is your feature request related to a problem? Please describe.
Yes, basically when we use "List" component with the mode "Delete", the default tooltip is "Delete". However in our context we use the List to remove a value, not delete it.

Describe the solution you'd like
Add a "tooltip" property to overload the default "delete" tooltip.

Describe alternatives you've considered
NA

Additional context
Unfortunately, we are forced to used List component cause the SAP Fiori standard.
@Lukas742
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Sep 19, 2022
@plamenivanov91
Copy link
Contributor

plamenivanov91 commented Sep 19, 2022 •
edited
Loading

Hello @SAP/ui5-webcomponents-topic-p ,

The reporter wants a way to set a custom tooltip to the 'X' button when the List is in 'Delete' mode.

Currently the tooltip defaults to 'Delete' but the user's use case is a bit different.

Could you please discuss if this feature request should be implemented?

Regards,
Plamen Ivanov

@dobrinyonkov
Copy link
Contributor

Internal Reference: BGSOFUIPIRIN-5928
A slot named deleteButton will be created.

plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Oct 25, 2022
@plamenivanov91
feat(ui5-li): introduce deleteButton slot
ea1374c 
Introduced delete button slot, that allows custom delete button.
If the slot is unused, the default delete button will be used instead.

Closes: SAP#5826
@plamenivanov91 plamenivanov91 mentioned this issue Oct 25, 2022
Merged
2 tasks
plamenivanov91 added a commit that referenced this issue Oct 27, 2022
@plamenivanov91
feat(ui5-li): introduce deleteButton slot (#5971)
ca40efd 
* feat(ui5-li): introduce deleteButton slot

Introduced delete button slot, that allows custom delete button.
If the slot is unused, the default delete button will be used instead.

Closes: #5826
@ilhan007 ilhan007 added this to the 1.9.0 milestone Oct 27, 2022
@petyabegovska petyabegovska moved this to Completed in Planning - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request TOPIC P
Projects
Planning - Topic P
Status: Completed
UI5 Web Components - Roadmap
Status: Q3
Milestone
1.9.0
Development

Successfully merging a pull request may close this issue.

feat(ui5-li): introduce deleteButton slot plamenivanov91/ui5-webcomponents
5 participants
@Lukas742 @plamenivanov91 @ilhan007 @dobrinyonkov @DanielCavemann