Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Topic RD] All components - issues after ACC testing #5827

Closed
4 tasks done
TeodorTaushanov opened this issue Sep 19, 2022 · 0 comments
Closed
4 tasks done

[Topic RD] All components - issues after ACC testing #5827

TeodorTaushanov opened this issue Sep 19, 2022 · 0 comments

Comments

@TeodorTaushanov
Copy link
Member

TeodorTaushanov commented Sep 19, 2022

  • ui5-label:
  • Label.for=inputId - label is not read, when the input is focused if accessible-name-ref="labelId" is not set (NVDA and JAWS).
    Can we do this automatically like in OpenUI5?

This HTML is read correctly:

<label for="input1">Enter something</label>
<input id="input1">

https://snippix.only.sap/snippets/72742

  • "*" is not read in Virtual Mode. Align it with OpenUi5
  • Required is not read - check the samples. Align it with OpenUi5?

https://codesandbox.io/s/ui5-dialog-accessible-name-forked-f11ceg

  • ui5-radio-button

  • remove aria-readonly for the root element (access continuum issue)

  • align it with the OpenUI5 RadioButton. Check all aria attributes - on root level and on the 'input' element.

  • ui5-side-navigation

  • In expanded mode, the "2 of 3" is not read when move with the arrow keys. It is read only the first time the focus goes there. Change it like in OpenUI5?

  • In collapsed mode the aria attributes should be aligned with the OpenUI5.

  • ui5-tabcontainer

  • Tab design (like design="Negative") is not read.

@TeodorTaushanov TeodorTaushanov added the bug This issue is a bug in the code label Sep 19, 2022
@LidiyaGeorgieva LidiyaGeorgieva removed the bug This issue is a bug in the code label Sep 26, 2022
LidiyaGeorgieva added a commit that referenced this issue Oct 3, 2022
LidiyaGeorgieva added a commit that referenced this issue Nov 11, 2022
LidiyaGeorgieva added a commit that referenced this issue Nov 25, 2022
* fix(ui5-side-navigation): fixed accessibility of the Popover

PartOf: #5827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants