Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][ui5-upload-collection] The illustration of empty state is not consistent with Horizon design #6271

Closed
1 of 4 tasks
i323808 opened this issue Jan 13, 2023 · 6 comments
Closed
1 of 4 tasks
Assignees
Milestone

Comments

@i323808
Copy link

i323808 commented Jan 13, 2023

Feature Request Description

According to https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2698916049#UploadCollection/Set(Horizon)-UploadCollection(Horizon)%E2%80%93Header, the illustration of empty state should be sapIllus-Scene-Tent.

Current illustration:
UploadCollection_empty_state

Horizon design:
UploadCollection_empty_state_design

Proposed Solution

A clear and concise description of the solution you would like to have.

Proposed Alternatives

A clear and concise description of any alternative solutions or features you've considered.

Additional Context

Add other context or screenshots related to the feature request here.

Priority

  • Low
  • Medium
  • High
  • Very High

A clear and concise description of the impact/urgency of the required feature.

Stakeholder Info (if applicable)

  • Organization: {...}
  • Business impact: {...}
@kineticjs kineticjs added bug This issue is a bug in the code Medium Prio TOPIC RD labels Jan 13, 2023
@kineticjs kineticjs self-assigned this Jan 13, 2023
@kineticjs kineticjs added enhancement New feature or request and removed bug This issue is a bug in the code labels Jan 13, 2023
@kineticjs
Copy link
Contributor

kineticjs commented Jan 13, 2023

Hi @SAP/ui5-webcomponents-topic-rd,
The spec for Horizon https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2698916049#UploadCollection/Set(Horizon)-EmptyStates specifies a theme-specific icon for the empty state. Do you plan to reflect this in the component?

@kineticjs kineticjs removed their assignment Jan 13, 2023
@olannyv
Copy link

olannyv commented Jan 17, 2023

The Upload Collection rendering for empty states is not yet using the Illustrated Messages.
It is valid and nice to have, just a matter of priority and capacity in the team ....

@i323808 - what is the application or scenario where you need/expect illustrated messages?
How would you rate the priority of having such?

@i323808
Copy link
Author

i323808 commented Jan 18, 2023

Hi @olannyv ,

Thanks for your reply.
We are using UploadCollection in "Apply for This Assignment" dialog of Opportunity Marketplace(SuccessFactors). We rolled out Horizon theme in the last release(b2211) and found the empty state of UploadCollection is different from other components which are using IllustratedMessage. Hopefully we can eliminate this UI inconsistency in the next release(b2305).

apply_dialog

success

Thanks,
Jane

@olannyv
Copy link

olannyv commented Jan 18, 2023

Hi, @i323808

I saw in the Spec three cases with specified Illustrated Message.
How about this (/) Success screen in your last answer - what is this "Great!" Illustrated Message?

Daniel

@i323808
Copy link
Author

i323808 commented Jan 19, 2023

Hi @olannyv ,

The "Success" dialog is another business scenario which are using IllustratedMessage, so it's UI is inconsistent with the empty state of UploadCollection. The IllustratedMessage name of "Success" dialog is "BalloonSky".

BR,
Jane

@olannyv
Copy link

olannyv commented Jan 24, 2023

Implementation BLI BGSOFUIRODOPI-2946 created
Pending execution based on team capacity and priorities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

5 participants