Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Localisation] nb not recognised as Norwegian #6283

Closed
1 task done
MapTo0 opened this issue Jan 16, 2023 · 0 comments · Fixed by #6284
Closed
1 task done

[Localisation] nb not recognised as Norwegian #6283

MapTo0 opened this issue Jan 16, 2023 · 0 comments · Fixed by #6284
Labels
bug This issue is a bug in the code TOPIC Core

Comments

@MapTo0
Copy link
Member

MapTo0 commented Jan 16, 2023 •
edited
Loading

Bug Description

When sap-ui-language=nb is set, the transitions fetched are not Norwegian

Expected Behavior

Norwegian texts are set to the components

Steps to Reproduce

  1. Go to any test page
  2. Place any component with translations
  3. Place a date-picker
  4. set url parameter to sap-ui-language=nb
  5. Datepicker is translated (CLDR is fetched) but other components are not

I guess that that mapping is missing https://github.com/SAP/openui5/blob/master/src/sap.ui.core/src/sap/base/i18n/ResourceBundle.js#L40-L69

Context

  • UI5 Web Components version: latest

Priority

  • [] Low
  • [] Medium
  • High
  • [] Very High

Stakeholder Info (if applicable)

  • Business impact: High
@MapTo0 MapTo0 added bug This issue is a bug in the code TOPIC Core labels Jan 16, 2023
@ilhan007 ilhan007 mentioned this issue Jan 16, 2023
Merged
ilhan007 added a commit that referenced this issue Jan 17, 2023
@ilhan007
fix(i18n): add mapping for norwegian locale (#6284)
7fef62f 
The change adds "nb": "no" to fallback to "no" locale, when "nb" is set.
In addition the mapping from the old ISO639 language code "in" to "id" removed to align with SAPUI5/OpenUI5 mappings, where "in" to "id" mapping has been also removed with SAP/openui5@b4efdf1

Fixes: #6283
s-todorova pushed a commit that referenced this issue Jan 20, 2023
@ilhan007 @s-todorova
fix(i18n): add mapping for norwegian locale (#6284)
88410b6 
The change adds "nb": "no" to fallback to "no" locale, when "nb" is set.
In addition the mapping from the old ISO639 language code "in" to "id" removed to align with SAPUI5/OpenUI5 mappings, where "in" to "id" mapping has been also removed with SAP/openui5@b4efdf1

Fixes: #6283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug in the code TOPIC Core
Projects
Maintenance - Topic Core
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(i18n): add mapping for norwegian locale SAP/ui5-webcomponents
1 participant
@MapTo0