Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFSF][A11y][MultiComboBox] Focus is lost after deleting the tokens and notification message is being read out by screen readers #6671

Closed
saorabhkr opened this issue Mar 8, 2023 · 4 comments · Fixed by #6734
Assignees
Labels

Comments

@saorabhkr
Copy link

Describe the bug

Describe the bug

With MultiComboBox, when we delete any tokens we have observed two things:

After deleting any token focus is not staying there on the previous/next token.

Upon deletion screen reader is not announcing "Token deleted" or anything.

The same can be seen here:
https://sap.github.io/ui5-webcomponents-react/?path=/story/inputs-multicombobox--default-story

Isolated Example

https://sap.github.io/ui5-webcomponents-react/?path=/story/inputs-multicombobox--default-story

Reproduction steps

Go to Demo Page

Select a few tokens from the dropdown
Delete the tokens
It's been observed that it's not retaining the focus.
Now delete any token and the announcement by NVDA/JAWS
It's not announcing anything.

Expected Behaviour

MultiComboBox:

After deleting any token focus should stay on the previous/next token

After deleting any token screen reader should announce some message eg: "Token deleted"
on

Screenshots or Videos

No response

UI5 Web Components for React Version

1.8.1

UI5 Web Components Version

1.10.5

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

@saorabhkr saorabhkr added the bug This issue is a bug in the code label Mar 8, 2023
@Lukas742
Copy link
Collaborator

Lukas742 commented Mar 8, 2023

Hi @saorabhkr

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

After deleting any token focus is not staying there on the previous/next token.

I have not been able to reproduce this. Please provide detailed steps on how this behavior occurs.

2023-03-08_08-50-45.mp4

Hi colleagues,

there is no dedicated announcement for token deletion. Could you please check if this is intentional?
There could also be an issue with focus after token deletion, but let's wait for the input of the author for a more detailed description of how to reproduce this.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Mar 8, 2023
@plamenivanov91
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rl ,

Currently if we focus a token in the MCB react default story and delete it with Backspace or Delete button, the tokens preview is closed (it says two more if there are two tokens for example).

The reporter claims that instead of closing the editing of the tokens, it should transfer the focus to the next/previous token and when we delete a Token, the screen reader should notify us about that action.

Are those claims valid, or the MCB works that way by design?

Could you please take over?

Regards,
Plamen Ivanov

@saorabhkr
Copy link
Author

Hi @Lukas742,

After deleting any token focus is not staying there on the previous/next token.
Please see the attached video, captured from storybook

Screen.Recording.2023-03-09.at.10.18.35.AM.mov

Also created an isolated example.
https://codesandbox.io/s/adoring-frost-pt0yit?file=/src/App.js

Please let me know if you need any other details.

Best Regards,
Saorabh

@saorabhkr
Copy link
Author

Hi @Lukas742,

We have found one more issue, with JAWS placeholder for MultiComboBox is not being read out. It should announce placeholder text with JAWS screen reader.

Best Regards,
Saorabh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants