Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[popover]: arrow is not centered when close to the border/with large text #7152

Closed
1 task done
rvsia opened this issue Jun 6, 2023 · 2 comments · Fixed by #8205
Closed
1 task done

[popover]: arrow is not centered when close to the border/with large text #7152

rvsia opened this issue Jun 6, 2023 · 2 comments · Fixed by #8205
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP Signavio SAP Signavio TOPIC RD

Comments

@rvsia
Copy link

rvsia commented Jun 6, 2023

Bug Description

The arrow of popover is not centered to the middle of target when it's close to the border of the screen or when there is a larger content

  1. close to the border

Snímek obrazovky 2023-06-06 v 9 05 33

  1. large content

Snímek obrazovky 2023-06-06 v 9 08 03

As we use only a small target for the popover, it looks really bad in our product

Snímek obrazovky 2023-06-06 v 9 20 27

Affected Component

popover

Expected Behaviour

Popover arrow is centered to the

Isolated Example

https://sap.github.io/ui5-webcomponents-react/?path=/docs/modals-popovers-popover--docs

Steps to Reproduce

  1. open webcompoments react popover page
  2. modify content of the popover using inspect

Log Output, Stack Trace or Screenshots

see above

Priority

Medium

UI5 Web Components Version

^1.13.2

Browser

Edge

Operating System

MacOS

Additional Context

No response

Organization

SAP Signavio

Declaration

  • I’m not disclosing any internal or sensitive information.
@rvsia rvsia added the bug This issue is a bug in the code label Jun 6, 2023
@elenastoyanovaa elenastoyanovaa self-assigned this Jun 7, 2023
@elenastoyanovaa
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rd ,

When the opener target is small and the popover does not have enough space the calculation of the arrow result in a unpleasant visualisation.

Steps to reproduce:

  • Open the playground sample of the popover
  • Change the button text to something small
  • Change the placement type of the popover to bottom
Screenshot 2023-06-07 at 21 48 47

Can you check?

Kind Regards,
Elena

@elenastoyanovaa elenastoyanovaa removed their assignment Jun 7, 2023
@georgimkv georgimkv self-assigned this Aug 1, 2023
@georgimkv
Copy link
Contributor

@georgimkv georgimkv removed their assignment Sep 11, 2023
@kskondov kskondov self-assigned this Sep 13, 2023
@kskondov kskondov removed their assignment Nov 6, 2023
@LidiyaGeorgieva LidiyaGeorgieva self-assigned this Nov 6, 2023
LidiyaGeorgieva added a commit that referenced this issue Nov 7, 2023
…elow the target

In case when the target is button with small width the arrow should be centered to the button.

Fixes #7152
@LidiyaGeorgieva LidiyaGeorgieva removed their assignment Nov 17, 2023
@dimovpetar dimovpetar self-assigned this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP Signavio SAP Signavio TOPIC RD
Projects
Status: Completed
6 participants