Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input: Value state cannot be changed dynamically #7681

Closed
1 task done
rvsia opened this issue Oct 6, 2023 · 4 comments · Fixed by #7882
Closed
1 task done

Input: Value state cannot be changed dynamically #7681

rvsia opened this issue Oct 6, 2023 · 4 comments · Fixed by #7882
Assignees
Labels
bug This issue is a bug in the code Medium Prio TOPIC RL
Milestone

Comments

@rvsia
Copy link

rvsia commented Oct 6, 2023

Describe the bug

When changing value state, it's not being rerendered when displayed leaving users to see the old state

Isolated Example

https://codesandbox.io/p/sandbox/adoring-hermann-vmxd56?file=%2Fsrc%2FApp.tsx%3A9%2C67

Reproduction steps

  1. add value state to Input
  2. change that value state when displayed (use timer, async function)
  3. no change

Expected Behaviour

Value is changed

Screenshots or Videos

Kapture 2023-10-06 at 09 37 36

UI5 Web Components for React Version

latest

UI5 Web Components Version

latest

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Relevant log output

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@rvsia rvsia added the bug This issue is a bug in the code label Oct 6, 2023
@Lukas742
Copy link
Collaborator

Lukas742 commented Oct 6, 2023

Hi @rvsia

I think you didn't save/fork the codeSandbox template, as the link only leads to our standard template. Could you please check that?

@rvsia
Copy link
Author

rvsia commented Oct 6, 2023

@Lukas742 Hi, thanks for noticing, I have fixed that! 😊

@Lukas742
Copy link
Collaborator

Lukas742 commented Oct 6, 2023

The issue is caused by the implementation of the web-component, since it's being developed in the UI5 Web Components repo, I will forward the issue there.


Hi colleagues,
the issue is reproducible using plain ui5-webcomponents without our wrapper. --> codeSandbox

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Oct 6, 2023
@Todor-ads
Copy link
Member

Hello @SAP/ui5-webcomponents-topic-rl ,
the issue is reproducible in https://codesandbox.io/p/sandbox/adoring-hermann-vmxd56?file=%2Fsrc%2FApp.tsx%3A9%2C67

Best regards,
Todor

@ivoplashkov ivoplashkov self-assigned this Nov 13, 2023
@ivoplashkov ivoplashkov assigned MapTo0 and unassigned ivoplashkov Nov 13, 2023
MapTo0 added a commit that referenced this issue Nov 21, 2023
`cloned` property should be set to true if the content of the
slot is being cloned to the static area. Common example is the valueStateMessage.

FIXES: #7681
MapTo0 added a commit that referenced this issue Nov 29, 2023
`cloned` property should be set to true if the content of the
slot is being cloned to the static area. Common example is the valueStateMessage.

FIXES: #7681
@ilhan007 ilhan007 added this to the 1.20.0 milestone Dec 4, 2023
PetyaMarkovaBogdanova pushed a commit that referenced this issue Dec 5, 2023
`cloned` property should be set to true if the content of the
slot is being cloned to the static area. Common example is the valueStateMessage.

FIXES: #7681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC RL
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

6 participants