Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DayPicker] Day names are overlapped in Portuguese #7831

Closed
1 task done
allen138 opened this issue Nov 9, 2023 · 1 comment · Fixed by #7866
Closed
1 task done

[DayPicker] Day names are overlapped in Portuguese #7831

allen138 opened this issue Nov 9, 2023 · 1 comment · Fixed by #7866
Assignees
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC B
Milestone

Comments

@allen138
Copy link

allen138 commented Nov 9, 2023

Bug Description

Hi team,

When user is using Portuguese lang, "pt_PT", the day names in the calendar pickers are overlapping. Please see:
image

The day names are using the 'ultraShortName', DayPicker.hbs#L20, which is the abbreviated name, DayPicker.ts#L359. The abbreviated names are slightly shorter than the 'wide' names as seen here, cldr/pt_PT.json#L1372-L1410, but when I test the classic SAPUI5 pickers, they actually use the 'narrow' day names which is determined with this logic: sap/ui/unified/calendar/MonthRenderer.js#L218-L222

Thanks,
Allen

Affected Component

Day Picker

Expected Behaviour

Day names should not overlap.

Isolated Example

https://codesandbox.io/s/ui5-webcomponents-forked-k9jn4f?file=/src/index.js

Steps to Reproduce

  1. Open the calendar picker and see the day names are overlapping.

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

main

Browser

Chrome, Edge

Operating System

All

Additional Context

No response

Organization

SF

Declaration

  • I’m not disclosing any internal or sensitive information.
@allen138 allen138 added the bug This issue is a bug in the code label Nov 9, 2023
@allen138 allen138 changed the title [DayPicker] Day names are overlapped in portugues [DayPicker] Day names are overlapped in Portuguese Nov 9, 2023
@tsanislavgatev
Copy link
Contributor

Hello colleagues,

Can you please have a look at this issue?

It's reproducible in the provided sample.

Best Regards,
Tsanislav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code High Prio SAP SF TOPIC B
Projects
Status: Completed
4 participants