Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: IllustratedMessage - expose part for subtitle div #7879

Closed
1 task done
Vir-Mittal opened this issue Nov 20, 2023 · 2 comments · Fixed by #8344
Closed
1 task done

[Feature Request]: IllustratedMessage - expose part for subtitle div #7879

Vir-Mittal opened this issue Nov 20, 2023 · 2 comments · Fixed by #8344
Assignees
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC P

Comments

@Vir-Mittal
Copy link

Feature Request Description

The illustrated message right now comes with the option of adding a subtitle as a slot. However, this slot is under the following div in the shadow root of the illustrated message -

And has the css property of max-width being 20rem

Would it be possible to expose this div as a part so that we can adjust the max-width of the text.

Basically right now we have something that looks like -

Screenshot 2023-11-20 at 11 34 56 AM

But want to get something that looks like -

Screenshot 2023-11-20 at 11 35 21 AM

Proposed Solution

Expose the shadow root div as a part so that the css can be modified

Proposed Alternatives

No response

Organization

SuccessFactors

Additional Context

No response

Priority

Medium

Privacy Policy

  • I’m not disclosing any internal or sensitive information.
@MapTo0
Copy link
Member

MapTo0 commented Nov 21, 2023

Hello @SAP/ui5-webcomponents-topic-p ,

This is a feature request to expose a part for the subtitle slot's wrapper so the use can enlarge the max-width.

While looking in the feature request I have also spotted a few issues with the Horizon implementation.
Subtitle has max-width: 30rem which is incorrect based on the Horizon spec.

Best Regards,
Martin

@dobrinyonkov
Copy link
Contributor

dobrinyonkov commented Jan 15, 2024

Hello @Vir-Mittal, your request was implemented with #8088. The issue mentioned by Martin will be handled with a seprate PR.

Kind Regards,
Dobrin

Edit: FR is implemented, only the visual issues described in the above comment remain unsolved. Moving to maintenance for implementing a fix.

@dobrinyonkov dobrinyonkov added bug This issue is a bug in the code Low Prio Medium Prio and removed feature request Low Prio labels Feb 20, 2024
@plamenivanov91 plamenivanov91 self-assigned this Feb 23, 2024
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Feb 23, 2024
plamenivanov91 added a commit that referenced this issue Feb 28, 2024
…#8344)

* fix(ui5-illustrated-message): title subtitle aligned with visual spec

Fixes: #7879
nnaydenow pushed a commit that referenced this issue Mar 20, 2024
…#8344)

* fix(ui5-illustrated-message): title subtitle aligned with visual spec

Fixes: #7879
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio SAP SF TOPIC P
Projects
Status: Completed
5 participants