Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui5-li]: remove _level property #8047

Closed
pskelin opened this issue Jan 3, 2024 · 1 comment · Fixed by #8089
Closed

[ui5-li]: remove _level property #8047

pskelin opened this issue Jan 3, 2024 · 1 comment · Fixed by #8089
Assignees
@yanaminkova
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@pskelin
Copy link
Contributor

pskelin commented Jan 3, 2024 •
edited
Loading

Bug Description

The ListItem class has a _level property that was introduced for private usage from the SideNavigationItemPopoverContent
Initial implementation #5877

The usage was later removed, but the property remained with the following change:
#6045

It seems safe to remove the property in the ListItem as it was introduced as private and has no other usages in the project.

Affected Component

ui5-li

UI5 Web Components Version

main
@pskelin pskelin added the bug This issue is a bug in the code label Jan 3, 2024
@NHristov-sap
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-p,

please take a look of this request/improvement.

Best Regards,
Nikolay Hristov

@yanaminkova yanaminkova self-assigned this Jan 11, 2024
@yanaminkova yanaminkova mentioned this issue Jan 11, 2024
Merged
yanaminkova added a commit that referenced this issue Jan 12, 2024
@yanaminkova
fix(ui5-list): removed _level property (#8089)
d0bc9eb 
Fixes: #8047

_level property is removed from ui5-li, since it is no longer used.
Also, import of 'Integer' is removed, since it is not used as well.
PetyaMarkovaBogdanova pushed a commit that referenced this issue Jan 17, 2024
@yanaminkova
fix(ui5-list): removed _level property (#8089)
9e7044e 
Fixes: #8047

_level property is removed from ui5-li, since it is no longer used.
Also, import of 'Integer' is removed, since it is not used as well.
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yanaminkova yanaminkova

Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-list): removed _level property SAP/ui5-webcomponents
3 participants
@pskelin @yanaminkova @NHristov-sap