Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui5-select: focus outline not presented over the selected option #8308

Closed
1 task done
niyap opened this issue Feb 20, 2024 · 1 comment
Closed
1 task done

ui5-select: focus outline not presented over the selected option #8308

niyap opened this issue Feb 20, 2024 · 1 comment
Assignees
@plamenivanov91
Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@niyap
Copy link
Contributor

niyap commented Feb 20, 2024

Bug Description

Going through the options, changing the selected one, there is no visual focus outline presented.

Affected Component

ui5-select

Expected Behaviour

Focus outline is visible on the focused option.

Isolated Example

https://sap.github.io/ui5-webcomponents/nightly/playground/main/pages/Select/

Steps to Reproduce

  1. Just check one random sample from the test page

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

Latest

Browser

Chrome

Operating System

MacOS

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@niyap niyap added bug This issue is a bug in the code TOPIC P labels Feb 20, 2024
@plamenivanov91 plamenivanov91 self-assigned this Apr 4, 2024
plamenivanov91 added a commit to plamenivanov91/ui5-webcomponents that referenced this issue Apr 11, 2024
@plamenivanov91
fix(ui5-select): options are now properly focused
8532a45 
Fixes: SAP#8308
@plamenivanov91 plamenivanov91 mentioned this issue Apr 11, 2024
Merged
plamenivanov91 added a commit that referenced this issue Apr 18, 2024
@plamenivanov91
fix(ui5-select): options are now properly focused (#8741)
4a61819 
Fixes: #8308
@plamenivanov91
Copy link
Contributor

Issue is fixed in the 1.24 branch. It will be fixed in 2.0/main branch once the refactoring of the option is done.

@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic P Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plamenivanov91 plamenivanov91

Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Maintenance - Topic P
Status: Completed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plamenivanov91 @niyap