Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: CheckBox displayOnly icon size #8326

Closed
1 task done
PlutaKatarzyna opened this issue Feb 21, 2024 · 2 comments · Fixed by #8423
Closed
1 task done

[Feature Request]: CheckBox displayOnly icon size #8326

PlutaKatarzyna opened this issue Feb 21, 2024 · 2 comments · Fixed by #8423

Comments

@PlutaKatarzyna
Copy link

Feature Request Description

Recently added feature (v1.23.0-rc.2) - checkbox display only state has hardcoded icon size equals to 1rem. We need possibility of overwriting the icon size to 24px.

Screenshot 2024-02-21 at 14 16 11

Proposed Solution

Add CSS variables to include possibility to overwrite ui5-icon inside ui5-checkbox component

Proposed Alternatives

Add shadow parts into checkbox ui5-icon component

Organization

SAP

Additional Context

UDEx components

Priority

None

Privacy Policy

  • I’m not disclosing any internal or sensitive information.
@ilhan007
Copy link
Member

Hi @SAP/ui5-webcomponents-topic-p, I looked at the request. Although it's about a new variable, I am in favour of exposing a part. I think introducing a part to the CheckBox icon is safe to expose, the icon looks like an integral part of the CheckBox and it's likely to stay in one or other form. What do you think, we can discuss if offline.

BR, ilhan

@dobrinyonkov
Copy link
Contributor

Internal Reference: BGSOFUIPIRIN-6487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants