fix(ui5-illustrated-message): vertical alignment #8566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent DOT feature led to improper vertical alignment of Illustrated Message's SVG when the IM is inside tall container. Now we make sure both the text and the SVG container are vertically centered in case of tall container. Fixes: SAP#8490
kgogov
approved these changes
Mar 28, 2024
ilhan007
pushed a commit
that referenced
this pull request
Apr 3, 2024
Recent DOT feature led to improper vertical alignment of Illustrated Message's SVG when the IM is inside tall container. Now we make sure both the text and the SVG container are vertically centered in case of tall container. Fixes: #8490
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent DOT feature led to improper vertical alignment of Illustrated Message's SVG when the IM is inside tall container. Now we make sure both the text and the SVG container are vertically centered in case of tall container.
Fixes: #8490