Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUploader: incorrect "drag and drop" area #8572

Closed
1 task done
nodari-dev opened this issue Mar 28, 2024 · 2 comments · Fixed by #8633
Closed
1 task done

FileUploader: incorrect "drag and drop" area #8572

nodari-dev opened this issue Mar 28, 2024 · 2 comments · Fixed by #8633
Assignees
@unazko
Labels
bug This issue is a bug in the code Medium Prio SAP Signavio SAP Signavio TOPIC B

Comments

@nodari-dev
Copy link

Describe the bug

Component area for "drag and drop" is not correct, so user needs to find a specific spot to upload a file

Isolated Example

No response

Reproduction steps

  1. Drag and drop file into FileUploader
  2. File will be opened in another tab (in my case it was a json file)

Expected Behaviour

"drag and drop" should be working for the whole area of FileUploader component

Screenshots or Videos

bug-ezgif com-optimize

UI5 Web Components for React Version

1.23.0 and higher

UI5 Web Components Version

1.21.0 and higher

Browser

Chrome, Safari

Operating System

Mac OS

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@nodari-dev nodari-dev added the bug This issue is a bug in the code label Mar 28, 2024
@Lukas742
Copy link
Collaborator

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Mar 28, 2024
@unazko unazko self-assigned this Mar 28, 2024
@unazko
Copy link
Contributor

unazko commented Mar 29, 2024

Hello @SAP/ui5-webcomponents-topic-b,

The inner input type "file" is transparent and has smaller size than the visual input and browse button.
The drag and drop operation works over the input type file element.

Best regards,
Boyan

@unazko unazko mentioned this issue Apr 4, 2024
Merged
@petyabegovska petyabegovska added the SAP Signavio SAP Signavio label Apr 10, 2024
unazko added a commit that referenced this issue Apr 23, 2024
@unazko
fix(ui5-file-uploader): adjust drop area
56bcab5 
Issue:

- A file could be dragged over a very small transparent area representing
the inner input type file. That would mean that the same file couldn't be
dropped over the most of the visible ui5-file-uploader DOM.
Solution:

- Dragged files will be dropped over the root component area.

Fixes: #8572
unazko added a commit to unazko/ui5-webcomponents that referenced this issue Apr 23, 2024
@unazko
fix(ui5-file-uploader): adjust drop area
934d3f0 
Issue:

- A file could be dragged over a very small transparent area representing
the inner input type file. That would mean that the same file couldn't be
dropped over the most of the visible ui5-file-uploader DOM.
Solution:

- Dragged files will be dropped over the root component area.

Fixes: SAP#8572
@unazko unazko mentioned this issue Apr 23, 2024
Merged
ilhan007 pushed a commit that referenced this issue May 10, 2024
@unazko
fix(ui5-file-uploader): adjust drop area (#8828)
cc7256a 
Issue:
- A file could be dragged over a very small transparent area representing
the inner input type file. That would mean that the same file couldn't be
dropped over the most of the visible ui5-file-uploader DOM.
Solution:
- Dragged files will be dropped over the root component area.

Fixes: #8572
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic B Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@unazko unazko

Labels
bug This issue is a bug in the code Medium Prio SAP Signavio SAP Signavio TOPIC B
Projects
Maintenance - Topic B
Status: Completed
ui5-webcomponents-react Roadmap
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui5-file-uploader): adjust drop area unazko/ui5-webcomponents
4 participants
@petyabegovska @Lukas742 @unazko @nodari-dev