Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DateRangePicker]: [a11y] missing accessible name for dateRangePicker popover #8598

Closed
1 task done
caroline-ferri opened this issue Apr 1, 2024 · 1 comment · Fixed by #8693
Closed
1 task done
Assignees
Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC B
Milestone

Comments

@caroline-ferri
Copy link

Bug Description

When the DateRangePicker with a set accessiblenName property is clicked and the calendar popover is displayed, the popover has no accessible name attribute. Popover with role="dialog" should have accessible name.
Screenshot 2024-04-01 at 1 26 06 PM

Affected Component

DateRangePicker

Expected Behaviour

When the accessibleName property is set for the DateRangePicker component, the DateRangePicker popover should also have a set accessible name.

Isolated Example

https://sap.github.io/ui5-webcomponents/playground/?path=/docs/main-daterangepicker--date-range-picker-overview

Steps to Reproduce

  1. Navigate to DateRangePicker storybook example https://sap.github.io/ui5-webcomponents/playground/?path=/docs/main-daterangepicker--date-range-picker-overview
  2. Set the accessibleName property to a string
  3. Open the dateRangePicker calendar popover
  4. Notice the popover has no accessible name set
    ...

Log Output, Stack Trace or Screenshots

No response

Priority

Medium

UI5 Web Components Version

1.23.1

Browser

Chrome

Operating System

Mac OS

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@caroline-ferri caroline-ferri added the bug This issue is a bug in the code label Apr 1, 2024
@dobrinyonkov dobrinyonkov self-assigned this Apr 2, 2024
@dobrinyonkov
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-b,

Could you please have a look into this? It seems that the DatePicker's popover does not have a required accessible name.
Aria 1.2 also mentions something about that - https://www.w3.org/TR/wai-aria-1.2/#dialog

Kind Regards,
Dobrin

@dobrinyonkov dobrinyonkov removed their assignment Apr 2, 2024
@unazko unazko self-assigned this Apr 4, 2024
unazko added a commit to unazko/ui5-webcomponents that referenced this issue Apr 9, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Fixes: SAP#8598
unazko added a commit to unazko/ui5-webcomponents that referenced this issue Jun 14, 2024
@ilhan007 ilhan007 added this to the 1.24.5 milestone Jun 18, 2024
@petyabegovska petyabegovska moved this to Completed in Maintenance - Topic B Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC B
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

4 participants