Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: fiori/BarcodeScannerDialog Support customizable dialog design #8919

Closed
1 task done
slin-sap opened this issue May 8, 2024 · 3 comments
Closed
1 task done

[Feature Request]: fiori/BarcodeScannerDialog Support customizable dialog design #8919

slin-sap opened this issue May 8, 2024 · 3 comments
Assignees
@jdichev
Labels
feature request Medium Prio TOPIC P
Milestone
2.6.0

Comments

@slin-sap
Copy link
Contributor

slin-sap commented May 8, 2024

Feature Request Description

BarcodeScannerDialog has a footer and cancel button built-in.

Our designer has different design. It would help if BarcodeScannerDialog also supports slots to accept customizable dialog appearance.

Proposed Solution

  • Support optional custom-header and custom-footer slots
  • When custom-footer slot is present, the default footer slot will not be rendered.
  • Version 2.0 implementation no longer expose close() method. Hopefully the equivalent API still exist that can be used to trigger close from customized close/cancel button. Also trigger close on listening to "scan-success" event.

Proposed Alternatives

No response

Organization

UX Engineering

Additional Context

No response

Priority

Medium

Privacy Policy

  • I’m not disclosing any internal or sensitive information.
@niyap niyap self-assigned this May 9, 2024
@niyap niyap removed their assignment May 9, 2024
@niyap
Copy link
Contributor

niyap commented May 9, 2024

Hello @SAP/ui5-webcomponents-topic-p,

Could you please take a look of that feature request?

Thank you in advance!

Kind Regards,
Niya

@jdichev jdichev self-assigned this May 14, 2024
@jdichev
Copy link

jdichev commented May 14, 2024

Team will look into this request. Internal reference: BGSOFUIPIRIN-6560

@dobrinyonkov dobrinyonkov moved this from New to Approved in Planning - Topic P Jun 21, 2024
@dobrinyonkov dobrinyonkov moved this from Approved to In Progress in Planning - Topic P Jul 10, 2024
@dobrinyonkov dobrinyonkov added this to the 2.1.0 milestone Jul 10, 2024
@dobrinyonkov dobrinyonkov modified the milestones: 2.1.0, 2.2.0 Jul 31, 2024
@dobrinyonkov dobrinyonkov modified the milestones: 2.2.0, 2.3.0 Sep 2, 2024
@dobrinyonkov dobrinyonkov modified the milestones: 2.3.0, 2.4.0 Oct 16, 2024
kgogov added a commit that referenced this issue Oct 21, 2024
@kgogov
feat(ui5-barcode-scanner-dialog): added support for custom header and…
56c252c 
… footer slots

This update introduces two new slot attributes for
`ui5-barcode-scanner-dialog`, allowing developers to customize the header
and footer of the dialog. If no custom content is provided, the dialog
will use its default layout. The new slots enhance flexibility for
developers, enabling the addition of custom titles, buttons, and any
other elements in the header and footer areas.

Related: #8919
@kgogov kgogov mentioned this issue Oct 21, 2024
Merged
kgogov added a commit that referenced this issue Oct 22, 2024
@kgogov
feat(ui5-barcode-scanner-dialog): added support for custom header and…
352c24b 
… footer slots

This update introduces two new slot attributes for
`ui5-barcode-scanner-dialog`, allowing developers to customize the header
and footer of the dialog. If no custom content is provided, the dialog
will use its default layout. The new slots enhance flexibility for
developers, enabling the addition of custom titles, buttons, and any
other elements in the header and footer areas.

Related: #8919
kgogov added a commit that referenced this issue Oct 22, 2024
@kgogov
feat(ui5-barcode-scanner-dialog): added support for custom header and…
4d06b2e 
… footer slots (#10066)

This update introduces two new slot attributes for
`ui5-barcode-scanner-dialog`, allowing developers to customize the header
and footer of the dialog. If no custom content is provided, the dialog
will use its default layout. The new slots enhance flexibility for
developers, enabling the addition of custom titles, buttons, and any
other elements in the header and footer areas.

Related: #8919
kgogov added a commit that referenced this issue Oct 30, 2024
@kgogov
feat(ui5-barcode-scanner-dialog): added support for custom header and…
52a6ff9 
… footer slots (#10066)

This update introduces two new slot attributes for
`ui5-barcode-scanner-dialog`, allowing developers to customize the header
and footer of the dialog. If no custom content is provided, the dialog
will use its default layout. The new slots enhance flexibility for
developers, enabling the addition of custom titles, buttons, and any
other elements in the header and footer areas.

Related: #8919
@ilhan007 ilhan007 modified the milestones: 2.4.0, 2.6.0 Dec 7, 2024
@dobrinyonkov
Copy link
Contributor

closed by #10066

@github-project-automation github-project-automation bot moved this from In Progress to Completed in Planning - Topic P Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdichev jdichev

Labels
feature request Medium Prio TOPIC P
Projects
Planning - Topic P
Status: Completed
Milestone
2.6.0
Development

No branches or pull requests
5 participants
@jdichev @ilhan007 @dobrinyonkov @niyap @slin-sap