Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wizard]: Stacked Wizard Steps not aligned properly #9779

Closed
1 task done
Neeeko opened this issue Aug 30, 2024 · 4 comments · Fixed by #10250
Closed
1 task done

[Wizard]: Stacked Wizard Steps not aligned properly #9779

Neeeko opened this issue Aug 30, 2024 · 4 comments · Fixed by #10250
Assignees
Labels
bug This issue is a bug in the code Low Prio released TOPIC RL

Comments

@Neeeko
Copy link

Neeeko commented Aug 30, 2024

Describe the bug

It's not extremely visible (although it's there) in the sample, but more visible in our application.

In smaller screens, the Stacked (or non selected) steps are not properly horizontally aligned with the other steps numbers.

In the following example, here's how it looks like with a screen width of about 450px:
https://stackblitz.com/edit/github-rhfduk?file=src%2FApp.tsx
Screenshot 2024-08-29 at 8 48 26 PM
Screenshot 2024-08-29 at 8 49 21 PM

Here's how it looks like in our application. It's way more visible.
Screenshot 2024-08-29 at 8 52 51 PM

I was unable to reproduce this issue in ui5-webcomponents playground.

Isolated Example

https://stackblitz.com/edit/github-rhfduk?file=src%2FApp.tsx

Reproduction steps

  1. Go to https://stackblitz.com/edit/github-rhfduk?file=src%2FApp.tsx
  2. Reduce the screen width to around 450px
  3. Go to step 4
  4. Notice the alignment issue

Expected Behaviour

All step numbers should be properly aligned.

Screenshots or Videos

No response

UI5 Web Components for React Version

latest

UI5 Web Components Version

latest

Browser

Chrome, Edge, Firefox, Safari

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@Neeeko Neeeko added the bug This issue is a bug in the code label Aug 30, 2024
@Lukas742
Copy link
Collaborator

Lukas742 commented Aug 30, 2024

Hi @Neeeko

Thanks for reporting! I'll forward this issue to our UI5 Web Components Colleagues as the affected component is developed in their repository.


Hi colleagues,

the Wizard steps are misaligned in some cases. I wasn't able to reproduce the hard misalignment as shown in the 3rd screenshot, but it's there. It's probably related to WizardSteps with a two line title, rendered in the same line as steps with only a one line title.

Here you can find an example using only ui5wc without our wrapper or React. Please note that I've added red lines above and below each step to visualize the issue better, if you want to remove the lines just remove addCustomCSS.

https://stackblitz.com/edit/github-xieya7?file=index.html,main.js,package.json

image

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Aug 30, 2024
@elenastoyanovaa elenastoyanovaa self-assigned this Aug 30, 2024
@elenastoyanovaa
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-rl ,

Could you please take a look of this alignment issue of the ui5-wizard navigation area?

Kind Regards,
Elena

@Neeeko
Copy link
Author

Neeeko commented Nov 20, 2024

Hi, any update on this ticket? This misalignment is quite visible in our project. Thanks!

@StefanDimitrov04 StefanDimitrov04 self-assigned this Nov 25, 2024
StefanDimitrov04 added a commit that referenced this issue Nov 27, 2024
FIXES: #9779

The solution: Added if statement that checks if there is subtitle-text attribute, so it is not rendered when not needed.
@github-project-automation github-project-automation bot moved this from In progress to Completed in Maintenance - Topic RL Nov 27, 2024
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This issue has been resolved in version v2.5.0-rc.2 🎉

The release is available on v2.5.0-rc.2

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Low Prio released TOPIC RL
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants