fix(ui5-popover): fix arrow position in RTL direction #10008
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the popover is inside iFrame in RTL direction and there is a scrollbar (in left) - the position of the popover (and its arrow) should be adjusted (moved to left with the size of the scrollbar). fixes: #9966
LidiyaGeorgieva
requested review from
TeodorTaushanov,
dimovpetar and
kskondov
and removed request for
TeodorTaushanov
dimovpetar
requested changes
Nov 5, 2024
| @@ -717,14 +743,35 @@ class Popover extends Popup { | |||
| return actualPlacement; | |||
| } | |||
|
|
|||
| isInsideIframe() { | |||
There was a problem hiding this comment.
Scrollbar is on the right side on Firefox.
Check why does it behave differently on Chromium based browsers only in iframes. Is this a known bug of Chromium?
There was a problem hiding this comment.
Unfortunately the Firefox behavior is the wrong one.
Here is open issue on the topic: https://bugzilla.mozilla.org/show_bug.cgi?id=619963
And also older report for Chromium: https://issues.chromium.org/issues/40322053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the popover is inside iFrame in RTL direction and
there is a scrollbar (in left) - the position of the popover
(and its arrow) should be adjusted (moved to left
with the size of the scrollbar).
fixes: #9966