feat(ui5-combobox/multi-combobox): physical items #10051
Conversation
|
@dobrinyonkov I have some changes in the list if something is not clear please contact me. Basically, Since the combobox and the multicombobox are filtering their items internally, I need to render inidividual slots just for filtered items. That breaks the Item Navigation in the list and I had to enhance it |
There was a problem hiding this comment.
combobox:
- go to Items with grouping
- press A and navigate through items
- the input field will eventually have a value Zimbabve which is not present in the list
- it seems that this item is part of the second visible group, but should not be part of the filtered items and should not be selected on navigation as it is filtered out
There was a problem hiding this comment.
multicombobox:
- the mcb item checkbox should have an accessible name. Check in UI5 and in the main of ui5 web components for the label and add it as an accessible name to the checkbox. It should be translatable as well.
-
Go to "Select all with groups". Press A to filter. Press the Select All - the items won't be selected. This works in main.
-
MultiComboBox with N-More and show wrapping - wrapping is broken
As this is reproducible in main as well we will ignore this comment. |
|
@nnaydenow please carefully check the cypress use case. We have MultiComboBox Items now physical. They are slotted, this means mcbElement.items always returns full list of the items, but just some of them are forwarded to the list. for the forwarded we add slot. How we should select such items in the test? |
| @@ -1,7 +1,7 @@ | |||
| {{>include "./ComboBoxItem.hbs"}} | |||
|
|
|||
| {{#*inline "listItemContent"}} | |||
| <ui5-checkbox ?checked="{{selected}}" tabindex="invalid" accessible-name="{{_accessibleName}}"></ui5-checkbox> | |||
| <ui5-checkbox ?disabled="{{_readonly}}" ?checked="{{selected}}" tabindex="invalid" accessible-name="{{_accessibleName}}"></ui5-checkbox> | |||
There was a problem hiding this comment.
what is the purpose of this? readonly MCB has no possibility to open the picker
| @@ -138,7 +138,7 @@ | |||
| {{#*inline "selectAllWrapper"}} | |||
| {{#if showSelectAll}} | |||
| <div class="ui5-mcb-select-all-header" @keydown="{{_onListHeaderKeydown}}" tabindex="0"> | |||
| <ui5-checkbox ?checked={{_allSelected}} class="ui5-mcb-select-all-checkbox" text="{{selectAllCheckboxLabel}}" @ui5-change="{{_handleSelectAllCheckboxClick}}"></ui5-checkbox> | |||
| <ui5-checkbox ?disabled={{this.readonly}} ?checked={{_allSelected}} class="ui5-mcb-select-all-checkbox" text="{{selectAllCheckboxLabel}}" @ui5-change="{{_handleSelectAllCheckboxClick}}"></ui5-checkbox> | |||
| } | ||
|
|
||
| :host([readonly]) ::slotted([ui5-mcb-item]) { |
There was a problem hiding this comment.
should not be a valid case
|
🎉 This PR is included in version v2.5.0-rc.0 🎉 The release is available on v2.5.0-rc.0 Your semantic-release bot 📦🚀 |
Passed items to the
ui5-comboboxandui5-multi-comboboxare now physically slotted to the internal list of the picker.