fix(ui5-color-picker): add tooltip to sliders #10270
Conversation
unazko
left a comment
unazko
left a comment
There was a problem hiding this comment.
Tooltips are present and with accurate values.
|
|
||
| _setMainColor(hueValue: number) { | ||
| if (hueValue <= 255) { | ||
| const hueValueMod = hueValue * 4.251; |
There was a problem hiding this comment.
Usually, assigning to a new variable (hueValueMod) and using it throughout the function, is necessary when you need both the passed param (hueValue) and the modified one (hueValueMod) at the same time. But if you'll only use the modified one, the best would be to just have: hueValue = hueValue * 4.251; and continue using hueValue in the function as before.
|
|
||
| _setMainColor(hueValue: number) { | ||
| if (hueValue <= 255) { | ||
| const hueValueMod = hueValue * 4.251; |
There was a problem hiding this comment.
I know this magic number existed before, but this refactoring is an opportunity to set it to a constant.
| // By using the selected coordinates(x = Lightness, y = Saturation) and hue(selected from the hue slider) | ||
| // and HSL format, the color will be parsed to RGB | ||
| // 0 ≤ H < 360 | ||
| // 4.251 because with 4.25 we get out of the colors range. |
There was a problem hiding this comment.
This comment is now obsolete and should be deleted not to cause confusion.
|
🎉 This PR is included in version v2.6.0-rc.0 🎉 The release is available on v2.6.0-rc.0 Your semantic-release bot 📦🚀 |
Now both of the sliders have tootip showing the value selected.
fixes: #10203