fix(ui5-menu-item): align arrow indication color #10695
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todor-ads
changed the title
hinzzx
approved these changes
Jan 29, 2025
vladitasev
reviewed
Jan 30, 2025
| @@ -108,11 +108,15 @@ | |||
| inset-inline-end: var(--_ui5_menu_item_submenu_icon_right); | |||
| } | |||
|
|
|||
| :host .ui5-menu-item-submenu-icon .ui5-menu-item-icon-end { | |||
There was a problem hiding this comment.
:host is redundant here and breaks the "flow" of the CSS file - usually :host selectors are first, and then the ones for the shadow root.
You don't need :host <SOME SELECTOR> - in this case :host is unnecessary.
You must use it when you need to check for something on the host:
:host([disabled]) <SOME SELECTOR>
For example:
:host([active]:not([disabled])) .ui5-li-root .ui5-li-icon {
color: var(--sapList_Active_TextColor);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.