-
Notifications
You must be signed in to change notification settings - Fork 273
fix(ui5-busy-indicator): update busy area opacity #11237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixes: #11224
Please consider changing the word order of the explanatory note: According to the specification, the default visualization for controls includes a disabled control with a BusyIndicator overlay. The correct parameters for color and opacity are now applied to calculate the background color of the busy area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, left one comment for possible improvement.
cbaadaf
to
e700c89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version v2.10.0-rc.1 🎉 The release is available on v2.10.0-rc.1 Your semantic-release bot 📦🚀 |
According to the specification, the default visualization for controls includes a disabled control with a BusyIndicator overlay. The correct parameters for color and opacity are now applied to calculate the background color of the busy area.
fixes: #11224