Skip to content

fix(ui5-busy-indicator): update busy area opacity #11237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 15, 2025

Conversation

s-todorova
Copy link
Contributor

@s-todorova s-todorova commented Apr 1, 2025

According to the specification, the default visualization for controls includes a disabled control with a BusyIndicator overlay. The correct parameters for color and opacity are now applied to calculate the background color of the busy area.

fixes: #11224

fixes: #11224
@s-todorova s-todorova requested review from a team and Stoev April 1, 2025 13:55
fix

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Stoev
Copy link

Stoev commented Apr 7, 2025

Please consider changing the word order of the explanatory note:

According to the specification, the default visualization for controls includes a disabled control with a BusyIndicator overlay. The correct parameters for color and opacity are now applied to calculate the background color of the busy area.

Copy link

@Stoev Stoev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one comment for possible improvement.

@s-todorova s-todorova force-pushed the busyIndicator_opacity branch from cbaadaf to e700c89 Compare April 9, 2025 13:53
@s-todorova s-todorova requested a review from dimovpetar April 10, 2025 14:23
@s-todorova s-todorova dismissed dimovpetar’s stale review April 10, 2025 14:23

Comments are addressed

@s-todorova s-todorova requested a review from dimovpetar April 14, 2025 11:58
@dimovpetar dimovpetar requested a review from aborjinik April 14, 2025 12:17
@s-todorova s-todorova requested a review from aborjinik April 15, 2025 07:17
Copy link
Contributor

@aborjinik aborjinik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aborjinik aborjinik dismissed their stale review April 15, 2025 10:50

LGTM now

@s-todorova s-todorova merged commit 637cdd0 into main Apr 15, 2025
12 checks passed
@s-todorova s-todorova deleted the busyIndicator_opacity branch April 15, 2025 11:29
@ui5-webcomponents-bot
Copy link
Collaborator

🎉 This PR is included in version v2.10.0-rc.1 🎉

The release is available on v2.10.0-rc.1

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-busy-indicator]: incorrect opacity and background
5 participants