Skip to content

refactor(ui5-toolbar): items made physical #11374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jun 2, 2025

Conversation

PetyaMarkovaBogdanova
Copy link
Contributor

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova commented Apr 22, 2025

This Pull Requests represents ui5-toolbar items, which were until now rendered as an abstract items, as physical.

Since Popover Static area is not presented anymore we now render the slotted toolbar items directly with jsxRenderer and semantic ui5-toolbar-*(item name) are now part of the shadow DOM of the ui5-toolbar.

Items now contain isOverflowed property, which can distinguish if the item is in the Toolbar or in the Overflow Popover.

Fixes: #10622

PetyaMarkovaBogdanova and others added 12 commits April 28, 2025 17:08

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova marked this pull request as ready for review May 9, 2025 12:59
PetyaMarkovaBogdanova added 2 commits May 11, 2025 20:38
…ents into toolbar-items-physical
Copy link
Contributor

@dobrinyonkov dobrinyonkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few class members that are no longer used can be deleted:

Toolbar

  • getRegisteredToolbarItemByID
    • and itemsDOM
  • getItemByID
  • hasItemWithText
    • and ToolbarItem's containsText
  • itemsWidthMeasured

ToolbarItem

  • containsText
  • toolbarTemplate
  • toolbarPopoverTemplate

PR's title needs to include the refactor semantic tag.
Also, we can describe a short summary of the changes in the PR's body.

PetyaMarkovaBogdanova added 5 commits May 13, 2025 10:49
@dobrinyonkov
Copy link
Contributor

PR's title needs to include the refactor semantic tag.
Also, a short summary describing the changes in the PR's body.

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova changed the title Toolbar items physical refactor(ui5-toolbar): items made physical May 27, 2025
@PetyaMarkovaBogdanova PetyaMarkovaBogdanova merged commit 3992b1d into main Jun 2, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui5-toolbar]:implement toolbar components as a physical one
2 participants