-
Notifications
You must be signed in to change notification settings - Fork 276
refactor(ui5-toolbar): items made physical #11374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 79216a5.
…ents into toolbar-items-physical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few class members that are no longer used can be deleted:
Toolbar
getRegisteredToolbarItemByID
- and
itemsDOM
- and
getItemByID
hasItemWithText
- and ToolbarItem's
containsText
- and ToolbarItem's
itemsWidthMeasured
ToolbarItem
containsText
toolbarTemplate
toolbarPopoverTemplate
PR's title needs to include the refactor
semantic tag.
Also, we can describe a short summary of the changes in the PR's body.
PR's title needs to include the refactor semantic tag. |
This Pull Requests represents ui5-toolbar items, which were until now rendered as an abstract items, as physical.
Since Popover Static area is not presented anymore we now render the slotted toolbar items directly with jsxRenderer and semantic ui5-toolbar-*(item name) are now part of the shadow DOM of the ui5-toolbar.
Items now contain isOverflowed property, which can distinguish if the item is in the Toolbar or in the Overflow Popover.
Fixes: #10622