Skip to content

feat(ui5-list): enable drag and drop for multiple items #11445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dobrinyonkov
Copy link
Contributor

TBD

@aborjinik
Copy link
Contributor

Why does it have to be so specific to the List? I would have expected something that every component could also benefit from, especially since the multi-drag ghost is quite a generic concept.

@aborjinik
Copy link
Contributor

aborjinik commented May 27, 2025

Thanks for your efforts on the table component but I must say I still find the current code integration for dragging multiple items overly complex. Before moving further, I suggest to discuss this in the smaller sync we have on Tuesdays and Thursdays. If this topic has already been covered, sorry I sometimes miss sessions due to parallel meetings.

IMHO, instead of introducing something like a movingItemsCount property on the component itself, we could expose an API e.g. DragRegistry.setMovingItemsCount(dragstartEvent, count/text) (if the dragstart event is not already stored by the DragRegistry)

This approach leaves the drag ghost handling to consumers via native dragstart event as would be expected in vanilla drag & drop implementations.

Let me know what you think, as mentioned we can discuss this in the sync meeting.

@dobrinyonkov
Copy link
Contributor Author

Thanks for your efforts on the table component but I must say I still find the current code integration for dragging multiple items overly complex. Before moving further, I suggest to discuss this in the smaller sync we have on Tuesdays and Thursdays. If this topic has already been covered, sorry I sometimes miss sessions due to parallel meetings.

IMHO, instead of introducing something like a movingItemsCount property on the component itself, we could expose an API e.g. DragRegistry.setMovingItemsCount(dragstartEvent, count/text) (if the dragstart event is not already stored by the DragRegistry)

This approach leaves the drag ghost handling to consumers via native dragstart event as would be expected in vanilla drag & drop implementations.

Let me know what you think, as mentioned we can discuss this in the sync meeting.

Thanks @aborjinik for this feedback! We've discussed this a few times during the sync meetings and decided to go with that approach. However, I will look into your suggestion and bring the topic once again for discussion. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants