-
Notifications
You must be signed in to change notification settings - Fork 275
feat(ui5-combobox, ui5-multi-combo-box, ui5-input, ui5-multi-input): link navigation in value state #11575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Okiana
wants to merge
9
commits into
main
Choose a base branch
from
link-navigation-value-state
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…link navigation in value state
…link navigation in value state
…link navigation in value state update tests
…link navigation in value state do not focus the value state message when navigating with up/down arrow keys, when suggestions are open; prevent up/down scrolling of the page when only value state message is open;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the implementation of the Popover API and its proper implementation in the input components, the navigation inside the value state message, became unattainable.
Тhe focus will be set inside the value state message by pressing the keyboard combination of Ctrl + Alt + F8/ Command+Option+F8 and will move only if the inside component are ui5-link.
If the inside components are more then one ui5-links, the navigation between will happen by pressing Tab and Shift + Tab
respectively for moving the focus forward/backward on the links.
If suggestions are available, when pressing the Down arrow key, the focus will be moved on the first suggestion.
BGSOFUIRILA-4069