fix(ui5-datetime-picker): set min width #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
requested changes
May 28, 2020
| @@ -0,0 +1,3 @@ | |||
| :host .ui5-datepicker-input { | |||
| min-width: 14.5rem; | |||
There was a problem hiding this comment.
I tested and for long formats (format-pattern="long"), like "Aug 18, 2020, 10:32:30 AM" it might still not be enough,
14.75 to 15rem would be more safe:
There was a problem hiding this comment.
Indeed, I tested the same but with "Apr". After your comment I noticed that "Aug" and "Sep" are longer in terms of pixels than "Apr" due to the variable-width font, so I increased to 15rem.
There was a problem hiding this comment.
This makes date-time picker width stand out when used alongside other inputs
for example:
ilhan007
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input length is not enough by several pixels and the text gets truncated/fully displayed whenever you focus/unfocus the component.
min-widthjust enough to show the whole valuecloses: #1696