Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-input): Support ariaLabelledBy #1873

Merged
merged 2 commits into from
Jun 25, 2020
Merged

feat(ui5-input): Support ariaLabelledBy #1873

merged 2 commits into from
Jun 25, 2020

Conversation

vladitasev
Copy link
Contributor

@vladitasev vladitasev commented Jun 25, 2020 •
edited
Loading

This change centralizes the logic for calculating effective aria label text based on ariaLabel and ariaLabelledBy. Then this text is set as ariaLabel inside the shadow root, where IDs from the outer DOM cannot be cross-referenced.

Sample usage:

	<ui5-input aria-label="Very important input"></ui5-input>

	<ui5-label id="enterNameLabel">Enter name: </ui5-label>
	<ui5-input aria-labelledby="enterNameLabel"></ui5-input>

closes: #1866

ilhan007
ilhan007 previously approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be rc.8

@vladitasev
Copy link
Contributor Author

should be rc.8

I'll fix it

@vladitasev vladitasev merged commit 2356cd0 into master Jun 25, 2020
@vladitasev vladitasev deleted the aria-label-support branch June 25, 2020 09:24
ilhan007 pushed a commit that referenced this pull request Jul 7, 2020
@vladitasev @ilhan007
feat(ui5-input): Support ariaLabelledBy (#1873)
1d78bbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fifoosid fifoosid fifoosid approved these changes

@ilhan007 ilhan007 Awaiting requested review from ilhan007

@MapTo0 MapTo0 Awaiting requested review from MapTo0

Assignees
No one assigned
Labels
for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Associating labels with input fields explicitly
3 participants
@vladitasev @ilhan007 @fifoosid