Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-flexlible-column-layout): Custom layouts configuration #1987

Merged
merged 2 commits into from
Jul 29, 2020

Conversation

vladitasev
Copy link
Contributor

This change adds a new property, letting users provide their completely custom layouts configuration. The change is experimental.

closes: #1972

@vladitasev vladitasev merged commit abd06d0 into master Jul 29, 2020
@vladitasev vladitasev deleted the fcl-custom-config-layout branch July 29, 2020 06:08
@gurkirpalgill
Copy link

gurkirpalgill commented Aug 7, 2020

I am using these settings:

"TwoColumnsStartExpanded": {
  layout: [0, "100%", 0],
  arrows: [
    { visible: true, dir: null },
    { visible: false, dir: null },
  ],
},
"TwoColumnsMidExpanded": {
  layout: ["25%", "75%", 0],
  arrows: [
    { visible: true, dir: "mirror" },
    { visible: false, dir: null },
  ],
},

When I click on the left arrow to collapse first column animation works, but when i click again to expand first column, animation does not work.

Probably this code in FlexibleColumnLayout.js

if (currentlyHidden) {
			// animate the width
			columnDOM.style.width = columnWidth;

			// hide column with delay to allow the animation runs entirely
			setTimeout(() => {
				columnDOM.classList.add("ui5-fcl-column--hidden");
			}, FlexibleColumnLayout.ANIMATION_DURATION);

			return;
		}

@ilhan007
Copy link
Member

Hi @gurkirpalgill can you please create a new issue for your problem and describe it. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ Feature Request ] [ FlexibleColumnLayout ] Need custom size for difference layout
3 participants