fix(ui5-input): Fix JS error thrown in IE #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
previously requested changes
Jul 28, 2020
| @@ -318,7 +319,7 @@ class Suggestions { | |||
| } | |||
|
|
|||
| _getItems() { | |||
| return [...this.responsivePopover.querySelectorAll("ui5-list>*")]; | |||
| return [...this.responsivePopover.querySelectorAll("ui5-li-suggestion-item, ui5-li-groupheader")]; | |||
There was a problem hiding this comment.
The reason I put >* before was that with the new hooks, people could create their own implementation with f.e. ui5-li-custom. At least add it here, if it is not possible to reliably get the children.
But before that, please try with:
[...this.responsivePopover.querySelector("ui5-list").children]There was a problem hiding this comment.
I see, I tried it and it works this way as well
vladitasev
approved these changes
Jul 28, 2020
ilhan007
added a commit
that referenced
this pull request
Jul 28, 2020
For some reason the statement "this.responsivePopover.querySelectorAll("ui5-list>*") always returns an empty array in IE, later leading to a JS error, when element from that array had to be accessed, so I had to tweak it a little bit.
FIXES: #2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the statement
"this.responsivePopover.querySelectorAll("ui5-list>*")always returns an empty array in IE,later leading to a JS error, when element from that array had to be accessed, so I had to tweak it a little bit. In addition:
is in separate Input_quickview.html page.
FIXES: #2019