fix(ui5-messagestrip): Close button now has the correct design #2029
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to
ui5-button
to support this change:iconSize
added, allowing the user control not only over the button size, but over the icon size as welliconOnly
mode, icon is now centeredButtons like this are now possible:
with the following markup:
ui5-messagestrip
was refactored:ui5-button
used to achieve the desired design and behavior for the close button (kb handling, hover, focus, etc..)ui5-button
behavior deletedonDefine
now awaits all resources simultaneouslyThe close button looks like:
closes: #1989