Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-tabcontainer): implement acc for overflowed items #2047

Merged
merged 3 commits into from
Aug 3, 2020
Merged

fix(ui5-tabcontainer): implement acc for overflowed items #2047

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec521dd
fix(ui5-tabcontainer): implement acc for overflowed items
fifoosid Jul 31, 2020
944a836
Merge branch 'master' into tc-overflow-acc
ilhan007 Aug 3, 2020
be2ca90
fix aria-disabled
ilhan007 Aug 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/main/src/TabInOverflow.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
type="{{this.overflowState}}"
?selected="{{this.effectiveSelected}}"
?disabled="{{this.effectiveDisabled}}"
aria-disabled="{{this.effectiveDisabled}}"
aria-selected="{{this.effectiveSelected}}"
aria-labelledby="{{this.ariaLabelledBy}}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that aria-disabled should be either "true|false" or not set at all. In this case, with "?", it will remain just aria-disabled.

There is also small difference in the VoiceOver announcement. Without the "?", when aria-disabled="true", VoiceOver mentions "dimmed" in addition to the item's text.

But, I am not an expert, you can double check it with our ACC experts.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is not correct to have only aria-disabled with no value. The 'dimmed' announcement is expected.

>
<div class="ui5-tab-overflow-itemContent">
{{#if this.icon}}
Expand Down