Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-tab-container): implement overflow-button slot #2192

Merged
merged 2 commits into from
Sep 14, 2020
Merged

feat(ui5-tab-container): implement overflow-button slot #2192

merged 2 commits into from
Sep 14, 2020

Conversation

fifoosid
Copy link
Contributor

@fifoosid fifoosid commented Sep 8, 2020

Fixes #2184

@fifoosid fifoosid changed the title feat(ui5-tab-container): implement overflo-button slot feat(ui5-tab-container): implement overflow-button slot Sep 8, 2020
vladitasev
vladitasev requested changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@vladitasev vladitasev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The custom button is always there, no matter if an overflow menu is needed or not:
image

The normal button hides/appears properly

packages/main/src/TabContainer.js Outdated Show resolved Hide resolved
packages/main/src/TabContainer.js Outdated Show resolved Hide resolved
packages/main/src/TabContainer.js Show resolved Hide resolved
@fifoosid fifoosid requested a review from vladitasev September 11, 2020 09:59
@ilhan007 ilhan007 modified the milestone: 0.23.2 Sep 14, 2020
@fifoosid fifoosid merged commit e91c200 into master Sep 14, 2020
@fifoosid fifoosid deleted the tabcontainer-menu-button branch September 14, 2020 07:27
fifoosid added a commit that referenced this pull request Sep 14, 2020
@fifoosid
feat(ui5-tab-container): implement overflow-button slot (#2192)
647ae84
Todor-ads pushed a commit to Todor-ads/ui5-webcomponents that referenced this pull request Sep 17, 2020
@fifoosid @Todor-ads
feat(ui5-tab-container): implement overflow-button slot (SAP#2192)
804f564
ilhan007 pushed a commit that referenced this pull request Oct 17, 2020
@fifoosid @ilhan007
feat(ui5-tab-container): implement overflow-button slot (#2192)
b38d50c
ilhan007 pushed a commit that referenced this pull request Nov 11, 2020
@fifoosid @ilhan007
feat(ui5-tab-container): implement overflow-button slot (#2192)
f8bd4fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev vladitasev approved these changes

Assignees
No one assigned
Labels
for review SAP SF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request][A11Y][TabContainer] Need a parameter to custom the aria-label text for overflow menu button
3 participants
@fifoosid @vladitasev @ilhan007