Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-range-slider): Add Range Slider component #2310

Merged
merged 56 commits into from
Nov 20, 2020
Merged

feat(ui5-range-slider): Add Range Slider component #2310

Show file tree
Hide file tree
Changes from 48 commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
92d3e95
Initial Slider POC essentials
ndeshev Oct 7, 2020
c67f585
Minor formatting fixes
ndeshev Oct 7, 2020
831da57
RangeSlider functionality improvements
ndeshev Oct 8, 2020
cd7e00d
Range selection functionality wip
ndeshev Oct 8, 2020
1954979
Range Slider concepts implemented
ndeshev Oct 8, 2020
415da4e
Most of the comments fixed
ndeshev Oct 9, 2020
f99f666
showTooltip property added for tooltiping current value, minor code c…
ndeshev Oct 9, 2020
15f3eaf
Tooltip functionality is introduced
ndeshev Oct 9, 2020
68d3400
Labels introduced
ndeshev Oct 11, 2020
b671445
Slider and Range Slider separation
ndeshev Oct 12, 2020
5eb2b54
Slider separation from the Range Slider functionality
ndeshev Oct 13, 2020
a6c4b34
SliderBase class introduced as a foundation of the Slider and Range S…
ndeshev Oct 13, 2020
5c26fc7
Dynamic manipulation of the inline styles fixed, some other minor cha…
ndeshev Oct 13, 2020
dd58f68
Bundling fix
ndeshev Oct 13, 2020
67da54a
Inline styling fixes
ndeshev Oct 15, 2020
ce40132
Minor fixes
ndeshev Oct 15, 2020
97afe65
Minor fixes 2
ndeshev Oct 15, 2020
db2f2fa
Cleanup & refactoring of the UI sync and onBeforeRendering cycle
ndeshev Oct 15, 2020
a825d06
Small formatting fixes
ndeshev Oct 15, 2020
74ccf26
Stepiphying the values now is improved as well as some other calculat…
ndeshev Oct 15, 2020
004f97b
calc improvements
ndeshev Oct 16, 2020
d6014de
Refactoring, resize handling implemented
ndeshev Oct 21, 2020
db456ef
Added support (handling) for touch and pointer event types
ndeshev Oct 21, 2020
1705983
Fiori 3 and Belize theming
ndeshev Oct 23, 2020
652de00
The high contrast variants of the Fiori 3 and Belize themes are added
ndeshev Oct 23, 2020
577c688
Refactor private/protected methods
ndeshev Oct 24, 2020
494694b
Add state storage for tracking state changes
ndeshev Oct 26, 2020
0e5e881
Introduce template inheritance. Slider & RangeSlider templates inheri…
ndeshev Oct 26, 2020
d9c9d87
Fix template inheritance
ndeshev Oct 26, 2020
ecc630f
Fixes and improvements from the code reviews
ndeshev Nov 2, 2020
e692495
Add playground samples, add aria-labelledby attribute to Slider's handle
ndeshev Nov 4, 2020
04685d6
fix touch handling bug, add since tag in the sample header, remove ar…
ndeshev Nov 4, 2020
da25fb0
InvisibleStyles removed from css
ndeshev Nov 4, 2020
e0a2350
Add RTL Support
ndeshev Nov 5, 2020
2c567d8
Add more documentation
ndeshev Nov 5, 2020
f2397a8
Add additional validations and normalizations, refactoring
ndeshev Nov 11, 2020
92055bc
Modify sample with the new name of the tickmarks prop
ndeshev Nov 11, 2020
dfd9375
Add tests, fix synchronization of the UI when min and max properties …
ndeshev Nov 13, 2020
0e4d37c
Perform linting
ndeshev Nov 13, 2020
3b68e23
Minor
ndshv Nov 13, 2020
0d878b0
Fix syncUIAndState bug. Show tooltips on disabled sliders
ndshv Nov 14, 2020
6fd6e7c
Implement last Range Slider improvements, rebase on top of the Slider
ndeshev Nov 16, 2020
2c9348c
Add appenddocs and since tags, sample fixes
ndeshev Nov 16, 2020
262f91d
Minor lintix fix
ndeshev Nov 16, 2020
bc28e30
Implement code reviews changes
ndeshev Nov 18, 2020
68bfb3f
Sync Slider.js and Slider's test with the Slider's PR
ndeshev Nov 18, 2020
738978e
Merge branch 'master' into range-slider
ndeshev Nov 18, 2020
296a1ce
Remove duplicated comment line
ndeshev Nov 18, 2020
24020e4
Code review improvements and refactoring
ndeshev Nov 18, 2020
dc03e3a
Fix firing of change event for both type of Sliders
ndeshev Nov 19, 2020
3cf1d7e
Merge remote-tracking branch 'upstream/master' into range-slider
ndeshev Nov 19, 2020
c11319b
Merge remote-tracking branch 'upstream/master' into range-slider
ndeshev Nov 19, 2020
7962829
Fix tooltips on mobile, fix range-slider handle styles
ndeshev Nov 20, 2020
deab7c7
Fix tooltips on mobile
ndeshev Nov 20, 2020
094c06a
Fix range-slider tests with the new handles and tooltips classes
ndeshev Nov 20, 2020
66bc3a0
Merge remote-tracking branch 'upstream/master' into range-slider
ndeshev Nov 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/main/bundle.esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ import ResponsivePopover from "./dist/ResponsivePopover.js";
import SegmentedButton from "./dist/SegmentedButton.js";
import Select from "./dist/Select.js";
import Slider from "./dist/Slider.js";
import RangeSlider from "./dist/RangeSlider.js";
import Switch from "./dist/Switch.js";
import MessageStrip from "./dist/MessageStrip.js";
import MultiComboBox from "./dist/MultiComboBox.js";
Expand Down
18 changes: 18 additions & 0 deletions packages/main/src/RangeSlider.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{{>include "./SliderBase.hbs"}}

{{#*inline "handles"}}
<div class="ui5-slider-handle start-handle" style="{{styles.startHandle}}">
{{#if showTooltip}}
<div class="ui5-slider-tooltip start-tooltip" style="{{styles.tooltip}}">
<span class="ui5-slider-tooltip-value">{{tooltipStartValue}}</span>
</div>
{{/if}}
</div>
<div class="ui5-slider-handle end-handle" style="{{styles.endHandle}}">
{{#if showTooltip}}
<div class="ui5-slider-tooltip end-tooltip" style="{{styles.tooltip}}">
<span class="ui5-slider-tooltip-value">{{tooltipEndValue}}</span>
</div>
{{/if}}
</div>
{{/inline}}
Loading