fix(ui5-dialog): Texts are no longer blurred in Chromium-based browsers #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgimkv
requested review from
dimovpetar,
TeodorTaushanov and
alexandar-mitsev
Fixes: #2270 Bug in Chromium-based browsers (https://bugs.chromium.org/p/chromium/issues/detail?id=783388) causes elements with transform translate applied to be blurred due to values ending up resulting in fractional values. As a workaround, ui5-dialog is now centered using position fixed (with top and left).
dimovpetar
requested changes
Oct 30, 2020
There was a problem hiding this comment.
- When draggable dialog is dragged, then resizing the window shouldn't recenter the dialog
- When resizable dialog is resized, also resizing the window shouldn't recenter the dialog
This is the behavior of the OpenUI5 Dialog https://openui5.hana.ondemand.com/entity/sap.m.Dialog/sample/sap.m.sample.Dialog
dimovpetar
reviewed
Oct 30, 2020
Waiting for a response from UX colleagues regarding this. |
TeodorTaushanov
approved these changes
Nov 2, 2020
georgimkv
requested review from
vladitasev,
ilhan007 and
fifoosid
and removed request for
alexandar-mitsev
dimovpetar
approved these changes
Nov 2, 2020
vladitasev
approved these changes
Nov 5, 2020
| } | ||
|
|
||
| onExitDOM() { | ||
| this._dragMouseMoveHandler = null; | ||
| this._dragMouseUpHandler = null; | ||
| ResizeHandler.deregister(this, this._screenResizeHandler); |
There was a problem hiding this comment.
This and the next line are repeated several times in the code - not a big deal but maybe move them to a separate function?
ilhan007
pushed a commit
that referenced
this pull request
Nov 17, 2020
ilhan007
pushed a commit
that referenced
this pull request
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2270
Bug in Chromium-based browsers (https://bugs.chromium.org/p/chromium/issues/detail?id=783388)
causes elements with transform translate applied to be blurred
due to values ending up resulting in fractional values.
As a workaround, ui5-dialog is now centered using position fixed (with top and left).