fix(ui5-dialog): apply initial focus after rendering #2551
Merged
+67
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the initial focus is applied also in cases when the dialog is opened before it is fully rendered. Fixes: SAP#2537
|
The build fails due to eslint errors, you can see them by running 345:21 error '&&' should be placed at the beginning of the line operator-linebreak
348:32 error Block must not be padded by blank lines padded-blocks |
ilhan007
reviewed
Dec 7, 2020
Now the initial focus is applied also in cases when the dialog is opened before it is fully rendered. Fixes: SAP#2537
ilhan007
reviewed
Dec 10, 2020
georgimkv
previously approved these changes
Dec 11, 2020
georgimkv
approved these changes
Dec 14, 2020
ilhan007
approved these changes
Dec 14, 2020
MapTo0
approved these changes
Dec 14, 2020
niyap
pushed a commit
to niyap/ui5-webcomponents
that referenced
this pull request
Dec 17, 2020
Now the initial focus is applied also in cases when the dialog is open before it is fully rendered. Fixes: SAP#2537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the initial focus is applied also in cases when the dialog
is opened before it is fully rendered.
Fixes: #2537
Thank you for your contribution! 👏
To get it merged faster, kindly review the checklist below:
Pull Request Checklist