Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(BarDesign/AvatarGroupType): fix call of generateTypeAcessors #2557

Closed
wants to merge 1 commit into from
Closed

fix(BarDesign/AvatarGroupType): fix call of generateTypeAcessors #2557

wants to merge 1 commit into from

Conversation

MarcusNotheis
Copy link
Collaborator

There are two types on generataTypeAcessors but one of them was not was present in those two enums, so the ui5-bar and the ui5-avatar-group were crashing.

Example: https://codesandbox.io/s/unruffled-shamir-p2099?file=/src/App.js

I wasn't brave enough to fix the typo in DataType.ts 🙂

@MarcusNotheis
Copy link
Collaborator Author

Closing this PR in favour of downporting #2500

@MarcusNotheis MarcusNotheis deleted the fix/data-types-generate-types-accessors branch December 9, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladitasev vladitasev Awaiting requested review from vladitasev

@ilhan007 ilhan007 Awaiting requested review from ilhan007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarcusNotheis