refactor(ui5-flexible-column-layout): Add more accessibility texts #2571
+66
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
previously approved these changes
Dec 11, 2020
fifoosid
approved these changes
Dec 15, 2020
vladitasev
added a commit
that referenced
this pull request
Dec 16, 2020
niyap
pushed a commit
to niyap/ui5-webcomponents
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way accessibility-related texts are provided in order to customize
FlexibleColumnLayout.A new property called
accessibilityTextsis added and it serves as a central place for all such texts.Note: Since this property is of type
Object, it does not support an attribute counterpart.BREAKING CHANGE: the
startColumnAccessibleName,midColumnAccessibleNameandendColumnAccessibleNameproperties have been removed. Use the newaccessibilityTextsproperty to provide these (as keys to the object).closes: #2183