Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-wizard): add parameter to selectionChange event #3034

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Mar 29, 2021

Backgorund
For certain cases, it is useful to provide info if the selection-change is fired due to user's click on a step within the step navigation (as the selection might also occur due to scrolling). For that, we are introducing a new event parameter, called changeWithClick.
The parameter would be true, whenever the event is due to user click on a step within the step navigation header, and false when fired due to user scrolling

Usage

wiz.addEventListener("selection-change", function (event) {
		console.log(event.detail.changeWithClick);
});

@ilhan007
Copy link
Member Author

FYI @Hubery-Shen

@ilhan007 ilhan007 merged commit 7ad94d2 into master Mar 30, 2021
@ilhan007 ilhan007 deleted the feat-wizard-event-param branch March 30, 2021 10:57
ilhan007 added a commit that referenced this pull request Mar 31, 2021
For certain cases, it is useful to provide info if the selection-change is fired due to user's click on a step within the step navigation (as the selection might also occur due to scrolling). For that, we are introducing a new event parameter, called changeWithClick.
The parameter would be true, whenever the event is due to user click on a step within the step navigation header, and false when fired due to user scrolling.
ilhan007 added a commit that referenced this pull request Mar 31, 2021
For certain cases, it is useful to provide info if the selection-change is fired due to user's click on a step within the step navigation (as the selection might also occur due to scrolling). For that, we are introducing a new event parameter, called changeWithClick.
The parameter would be true, whenever the event is due to user click on a step within the step navigation header, and false when fired due to user scrolling.
ilhan007 added a commit that referenced this pull request Mar 31, 2021
For certain cases, it is useful to provide info if the selection-change is fired due to user's click on a step within the step navigation (as the selection might also occur due to scrolling). For that, we are introducing a new event parameter, called changeWithClick.
The parameter would be true, whenever the event is due to user click on a step within the step navigation header, and false when fired due to user scrolling.
@ilhan007
Copy link
Member Author

ilhan007 commented Apr 1, 2021

Hello @Hubery-Shen the event parameter is released with 0.29.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants