Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-checkbox, ui5-radiobutton): rename "readOnly" to "readonly" #413

Merged
merged 2 commits into from
May 20, 2019

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented May 20, 2019

The property "readOnly" is renamed to "readonly" in both ui5-checkbox and ui5-radiobutton
components to make the API consistent with ui5-input and ui5-datepicker, where the property is already called "readonly".
Fixes: #412

BREAKING CHANGE: property "readOnly" is renamed to "readonly" in both ui5-checkbox and ui5-radiobutton.

@ilhan007 ilhan007 requested review from vladitasev and pskelin May 20, 2019 08:48
@ilhan007 ilhan007 merged commit c2eba4e into master May 20, 2019
@ilhan007 ilhan007 deleted the refactor-property-rename branch May 20, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

property naming issue: 'readOnly' or 'readonly'
2 participants