Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-combobox, ui5-textarea): Value state message correctly positioned in RTL mode #4396

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

niyap
Copy link
Contributor

@niyap niyap commented Nov 29, 2021

No description provided.

@ilhan007
Copy link
Member

ilhan007 commented Nov 29, 2021

FYI: We try to start the commit messages with a verb, small letter and in imperative form, for example the current one would become:

fix(ui5-combobox, ui5-textarea): correct value state message placement in RTL
fix(ui5-combobox, ui5-textarea): fix value state message placement in RTL

When you press the "Squash and merge" button you will have the chance to fix the commit message.
Note: If you edit the PR commit message via the Github UI, which is also fine, you will anyway have to update it once more when you press the "Squash and merge" button.

@niyap niyap merged commit 6ab9edb into SAP:master Nov 29, 2021
@niyap
Copy link
Contributor Author

niyap commented Nov 29, 2021

FYI: We try to start the commit messages with a verb, small letter and in imperative form, for example the current one would become:

fix(ui5-combobox, ui5-textarea): correct value state message placement in RTL fix(ui5-combobox, ui5-textarea): fix value state message placement in RTL

When you press the "Squash and merge" button you will have the chance to fix the commit message. Note: If you edit the PR commit message via the Github UI, which is also fine, you will anyway have to update it once more when you press the "Squash and merge" button.

Thanks!

ndeshev pushed a commit to ndeshev/ui5-webcomponents that referenced this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants