-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-radio-button): add accessibleNameRef property #4511
Conversation
@@ -174,8 +175,7 @@ const metadata = { | |||
}, | |||
|
|||
/** | |||
* Defines the text alternative of the component. | |||
* If not provided a default text alternative will be set, if present. | |||
* Defines the accessible name of the component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure that this is self explanatory enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have taken this sentence from the other components. The second sentence "If not provided a default text ..." is not completely true, so I removed it.
I think we can add something like in Openui5 - https://openui5.hana.ondemand.com/api/sap.m.RadioButton#associations "see WAI-ARIA attribute aria-label". But we should do this for all components or not at all. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is explanatory enough. What is more, additional information could be found in the accessibility documentation.
@@ -174,8 +175,7 @@ const metadata = { | |||
}, | |||
|
|||
/** | |||
* Defines the text alternative of the component. | |||
* If not provided a default text alternative will be set, if present. | |||
* Defines the accessible name of the component. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is explanatory enough. What is more, additional information could be found in the accessibility documentation.
Related to #4501