fix(ui5-card-header): fix rtl support #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimovpetar
requested changes
Dec 30, 2021
There was a problem hiding this comment.
The status text now appears as "of 6 3".
I think the issue reports a problem with dir="{{effectiveDir}}" usage in CardHeader.hbs. In the playground UI5Element.prototype.effectiveDir returns rtl, but the attribute of the header is not set. For some reason this problem is not there when the playground is started on localhost.
dimovpetar
approved these changes
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4451
The root cause of the issue was a
dir="auto"set on the inner span in the shadow root of the component.Moreover, the padding was not applied at all if
actionslot was present. This is fixed in this PR as well.