fix: make static are items recognizable to openui5 dialogs #5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
reviewed
Oct 6, 2022
| @@ -17,6 +17,7 @@ class StaticAreaItem extends HTMLElement { | |||
| this._rendered = false; | |||
| this.attachShadow({ mode: "open" }); | |||
| this.pureTagName = "ui5-static-area-item"; | |||
| this.popupIntegrationAttr = "data-sap-ui-integration-popup-content"; | |||
There was a problem hiding this comment.
Better to have this as a constant in the module directly
packages/base/src/StaticAreaItem.js
Outdated
| this._updateContentDensity(); | ||
| this._updateDirection(); | ||
| this._updateAdditionalAttrs(); |
There was a problem hiding this comment.
Maybe this is not a problem at all, but it would be safest IMO to move this method call to where the old this.setAttribute was (before updateContentDensity and updateDirection) so that we don't break any functionality in these methods that relies on this.pureTagName, if such exists.
vladitasev
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When UI5WC ui5-date-picker is opened inside UI5 dialog, click "ESC" wrongly close whole dialog.
Root cause
It's an integration issue between UI5WC Popups and OpenUI5 Popups - the focus never gets to the DatePicker's popover as it's not recognized as an external content by the sap.m.Dialog.
Solution
While we are working on more general, out of the box solution by integrating UI5WC Popups and OpenUI5 Popups, we would like to provide the following solution for the time being:
Forwarding the
"data-sap-ui-integration-popup-content"attribute from the component that opens popup to its the static are item, which makes the static are item an external content for the sap.m.Dialog (as the aforementioned attribute is already part of the OpenUI5 logic). When the attribute is present, the focus goes inside the DatePicker's popover and the ESC behaviour works as expected.Related to: #5634