-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-input/ui5-multi-input/ui5-combobox/ui5-multi-combobox): min-width and margin #6044
Conversation
…idth and margin specs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I haven't tested the change yet, because I want to wait the final decision from the designers.
Check Ivo's comments as wel |
Hi colleagues, just to make sure you will also fix the the description properly - the commit message is not compliant to the commit msg guidelines. |
--_ui5_input_inner_padding_left_no_tokens and the left padding of --_ui5_input_inner_padding_with_icon are the same values, so remove the redundant CSS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes have been requested, you can find the comments inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now looks fine
Fixes: #5032 |
We have identified a gap in the min-width implementation of the inputs. Another issue found was the missing top and bottom margin of the input components. With this PR we would like to address these issues and: