Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui5-input/ui5-multi-input/ui5-combobox/ui5-multi-combobox): min-width and margin #6044

Merged
merged 42 commits into from
Feb 13, 2023

Conversation

mindarelus
Copy link
Contributor

@mindarelus mindarelus commented Nov 15, 2022

We have identified a gap in the min-width implementation of the inputs. Another issue found was the missing top and bottom margin of the input components. With this PR we would like to address these issues and:

  • add the missing top and bottom margin of all input components
  • create a sample page with all Inputs
  • update the implementation of the min-width of the ui5-input/ui5-multi-input/ui5-combobox/ui5-multi-combobox components to follow the design and match the one in UI5.

@mindarelus mindarelus requested a review from ndeshev November 21, 2022 13:44
Copy link
Member

@ivoplashkov ivoplashkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I haven't tested the change yet, because I want to wait the final decision from the designers.

packages/main/src/Input.js Outdated Show resolved Hide resolved
packages/main/src/MultiInput.hbs Outdated Show resolved Hide resolved
packages/main/src/MultiInput.js Outdated Show resolved Hide resolved
packages/main/src/MultiInput.js Outdated Show resolved Hide resolved
packages/main/src/themes/base/Input-parameters.css Outdated Show resolved Hide resolved
packages/main/src/themes/sap_horizon/Input-parameters.css Outdated Show resolved Hide resolved
packages/main/src/ComboBox.js Outdated Show resolved Hide resolved
packages/main/src/MultiComboBox.js Show resolved Hide resolved
packages/main/src/MultiInput.js Outdated Show resolved Hide resolved
@MapTo0
Copy link
Member

MapTo0 commented Dec 9, 2022

Check Ivo's comments as wel

@ilhan007
Copy link
Member

Hi colleagues, just to make sure you will also fix the the description properly - the commit message is not compliant to the commit msg guidelines.

packages/main/src/themes/MultiComboBox.css Outdated Show resolved Hide resolved
packages/main/src/themes/MultiComboBox.css Outdated Show resolved Hide resolved
packages/main/src/themes/MultiInput.css Outdated Show resolved Hide resolved
packages/main/src/themes/MultiInput.css Outdated Show resolved Hide resolved
@ndeshev
Copy link
Contributor

ndeshev commented Jan 30, 2023

--_ui5_input_inner_padding_left_no_tokens and the left padding of --_ui5_input_inner_padding_with_icon are the same values, so remove the redundant CSS

@MapTo0 MapTo0 dismissed stale reviews from ndeshev and ivoplashkov February 3, 2023 12:43

already applied

Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been requested, you can find the comments inline.

Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now looks fine

@mindarelus mindarelus merged commit ba805c6 into main Feb 13, 2023
@nnaydenow nnaydenow deleted the inputs-min-width-and-margin branch February 14, 2023 13:16
@hristop
Copy link
Contributor

hristop commented Feb 16, 2023

Fixes: #5032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants