Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable TS in main, fiori #6064

Merged
merged 17 commits into from
Nov 21, 2022
Merged

feat: enable TS in main, fiori #6064

merged 17 commits into from
Nov 21, 2022

Conversation

ilhan007
Copy link
Member

@ilhan007 ilhan007 commented Nov 17, 2022

The PR introduces the following changes:

project build

  • rework the project build to always prepare base and then main, fiori (currently done in parallel) so that Typescript finds all dependencies when running on components from main, fiori.

base package

  • several "base" types refactored to pure Enum whenever possible - see ValueState, CalendarType, etc.
  • type PopupState removed as not used
  • UI5ElementMetadata handles the pure Enum case (see UI5ElementMetadata#validateSingleProperty)

main package

  • package enabled to use TS
  • Label, Title and Icon are now in written Typescript
  • All types are in TS

fiori package

  • package enabled to use TS

@@ -1,6 +1,7 @@
import UI5Element from "@ui5/webcomponents-base/dist/UI5Element.js";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @gmkv

@ilhan007 ilhan007 merged commit 0b56130 into main Nov 21, 2022
@ilhan007 ilhan007 deleted the feat-ts-main branch November 21, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants