Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-illustrated-message): migrate to TS #6195

Merged
merged 7 commits into from
Dec 16, 2022
Merged

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Dec 15, 2022

With this change:

  • Migrated the Illustrated-message component to TypeScript.
  • Added slightly different logic in the onBeforeRendering() method - for validating if a given illustration name is correct or not.
    • If inccorect illustration name is provided - a warning is now given in the console, which let the developer know that there may be either a typo or wrong illustration name, and as same as before the default one ( "BeforeSearch" ) is loaded and shown.
  • Error messages for missing modules are a little bit more specific now aswell;

@ilhan007 ilhan007 merged commit 046c779 into main Dec 16, 2022
@ilhan007 ilhan007 deleted the research-illustrations branch December 16, 2022 11:49
@ilhan007
Copy link
Member

@SAP/ui5-webcomponents-topic-p FYI

@nnaydenow nnaydenow changed the title feat: migrate illustrated-message component to TS, small refactor refactor(ui5-illustrated-message): migrate to TS Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants