feat(ui5-message-strip): convert to Typescript #6248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
reviewed
Jan 5, 2023
ilhan007
reviewed
Jan 5, 2023
ilhan007
reviewed
Jan 5, 2023
nnaydenow
reviewed
Jan 5, 2023
nnaydenow
reviewed
Jan 6, 2023
|
|
||
| type DesignTypeAnnouncemnt = Record<MessageStripDesign, string>; | ||
|
|
||
| /** |
There was a problem hiding this comment.
this jsdoc comment seems to be redundant since metadata is missing.
nnaydenow
reviewed
Jan 6, 2023
packages/main/src/MessageStrip.ts
Outdated
| } | ||
|
|
||
| _closeClick() { | ||
| this.fireEvent("close", {}); |
There was a problem hiding this comment.
this empty object is redundant
nnaydenow
reviewed
Jan 6, 2023
packages/main/src/MessageStrip.ts
Outdated
| import event from "@ui5/webcomponents-base/dist/decorators/event.js"; | ||
| import customElement from "@ui5/webcomponents-base/dist/decorators/customElement.js"; | ||
| import languageAware from "@ui5/webcomponents-base/dist/decorators/languageAware.js"; | ||
| import { ClassMap } from "@ui5/webcomponents-base/dist/types.js"; |
nnaydenow
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
It looks good to me. @ilhan007 @vladitasev could you check it too?
ilhan007
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageStrip component migrated to TS.
Related to: #6080 #4337