Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-li-notification, ui5-li-notification-group): migrate to TypeScript #6568

Merged
merged 7 commits into from
Feb 24, 2023
Merged

feat(ui5-li-notification, ui5-li-notification-group): migrate to TypeScript #6568

merged 7 commits into from
Feb 24, 2023

Conversation

hinzzx
Copy link
Contributor

@hinzzx hinzzx commented Feb 22, 2023 •
edited
Loading

With this change, the following files are now converted to TypeScript:

  • NotificationListItem.js => NotificationListItem.ts,
  • NotificationListGroupItem.js => NotificationListGroupItem.ts
  • NotificationListItemBase.js => NotificationListItemBase.ts
  • NotificationAction.js => NotificationAction.ts

Fixes: #6420

@ilhan007
Copy link
Member

NotificationAction is a small abstract element, part of this family and we need to migrate it as well.
Initially I did not think of it. Could you add it to the PR as well.

@ilhan007 ilhan007 requested a review from georgimkv February 23, 2023 07:18
georgimkv
georgimkv suggested changes Feb 23, 2023
View reviewed changes
packages/fiori/src/NotificationAction.ts Outdated Show resolved Hide resolved
packages/fiori/src/NotificationAction.ts Show resolved Hide resolved
packages/fiori/src/NotificationListItemBase.ts Outdated Show resolved Hide resolved
@ilhan007
Copy link
Member

Hello @gmkv to me it's fine now, could you approve on behalf of @SAP/ui5-webcomponents-topic-rd . Thank you.

@hinzzx hinzzx merged commit 15dfc6e into main Feb 24, 2023
@hinzzx hinzzx deleted the nli-nlgi-to-ts branch February 24, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgimkv georgimkv georgimkv approved these changes

@ilhan007 ilhan007 ilhan007 approved these changes

@vladitasev vladitasev Awaiting requested review from vladitasev

@nnaydenow nnaydenow Awaiting requested review from nnaydenow

@pskelin pskelin Awaiting requested review from pskelin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NotificationListItem, NotificationGroupItem, NotificationAction: migrate to TS
3 participants
@hinzzx @ilhan007 @georgimkv