refactor(framework): add type module to package.json #6617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pskelin
approved these changes
Mar 31, 2023
didip1000
pushed a commit
that referenced
this pull request
Apr 4, 2023
* refactor(framework): add type module to package.json * chore: add fiori package * chore: sidenavigation tests * chore: shellbar tests * chore: main tests * chore: main tests * chore: add icons/localization/theming * chore: vite to esm * chore: lint * chore: lint * chore: lint * chore: make all configs common js * chore: enable base test * chore: vite to commonjs * chore: tools to cjs * chore: cjs or js * chore: fix build * chore: add eslintrc to main * chore: update eslint to cjs * chore: add tests for ssr * chore: add eslint ignore * refactor(framework): add type module to package.json * chore: add fiori package * chore: sidenavigation tests * chore: shellbar tests * chore: main tests * chore: main tests * chore: add icons/localization/theming * chore: vite to esm * chore: lint * chore: lint * chore: make all configs common js * chore: enable base test * chore: vite to commonjs * chore: tools to cjs * chore: cjs or js * chore: fix build * chore: add eslintrc to main * chore: update eslint to cjs * chore: add tests for ssr * chore: add eslint ignore * chore: rebase --------- Co-authored-by: Nayden Naydenov <nnaydenow.work@sap.com>
NHristov-sap
pushed a commit
that referenced
this pull request
May 4, 2023
* refactor(framework): add type module to package.json * chore: add fiori package * chore: sidenavigation tests * chore: shellbar tests * chore: main tests * chore: main tests * chore: add icons/localization/theming * chore: vite to esm * chore: lint * chore: lint * chore: lint * chore: make all configs common js * chore: enable base test * chore: vite to commonjs * chore: tools to cjs * chore: cjs or js * chore: fix build * chore: add eslintrc to main * chore: update eslint to cjs * chore: add tests for ssr * chore: add eslint ignore * refactor(framework): add type module to package.json * chore: add fiori package * chore: sidenavigation tests * chore: shellbar tests * chore: main tests * chore: main tests * chore: add icons/localization/theming * chore: vite to esm * chore: lint * chore: lint * chore: make all configs common js * chore: enable base test * chore: vite to commonjs * chore: tools to cjs * chore: cjs or js * chore: fix build * chore: add eslintrc to main * chore: update eslint to cjs * chore: add tests for ssr * chore: add eslint ignore * chore: rebase --------- Co-authored-by: Nayden Naydenov <nnaydenow.work@sap.com>
PetyaMarkovaBogdanova
pushed a commit
that referenced
this pull request
Jun 20, 2023
* refactor(framework): add type module to package.json * chore: add fiori package * chore: sidenavigation tests * chore: shellbar tests * chore: main tests * chore: main tests * chore: add icons/localization/theming * chore: vite to esm * chore: lint * chore: lint * chore: lint * chore: make all configs common js * chore: enable base test * chore: vite to commonjs * chore: tools to cjs * chore: cjs or js * chore: fix build * chore: add eslintrc to main * chore: update eslint to cjs * chore: add tests for ssr * chore: add eslint ignore * refactor(framework): add type module to package.json * chore: add fiori package * chore: sidenavigation tests * chore: shellbar tests * chore: main tests * chore: main tests * chore: add icons/localization/theming * chore: vite to esm * chore: lint * chore: lint * chore: make all configs common js * chore: enable base test * chore: vite to commonjs * chore: tools to cjs * chore: cjs or js * chore: fix build * chore: add eslintrc to main * chore: update eslint to cjs * chore: add tests for ssr * chore: add eslint ignore * chore: rebase --------- Co-authored-by: Nayden Naydenov <nnaydenow.work@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
type:moduleto all packages except ui5-webcomponents-tools. With current versions tools like postcss,wdio doesn't support both module type ESM / CJS so CJS is preferred. In order to make them work we have to upgrade tool version.Fixes: #6449